Only clusters with a non-None rect can become active parents during m…#155
Conversation
…embership walking. No-rect clusters are now transparent, so descendants fall back to the nearest rendered ancestor. Implemented a CI hang guard.
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the cluster membership logic in graphviz2drawio to ignore clusters without rendered rectangles, allowing nodes to be parented by their nearest rendered ancestor. It also introduces rendering timeout support in drawio_export.sh using timeout or gtimeout, disables GPU and dev-shm-usage on Linux, and adds corresponding unit tests. Feedback suggests simplifying the timeout command detection in the shell script to avoid redundant command checks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| if command -v timeout > /dev/null 2>&1; then | ||
| command -v timeout | ||
| return 0 | ||
| fi | ||
|
|
||
| if command -v gtimeout > /dev/null 2>&1; then | ||
| command -v gtimeout | ||
| return 0 | ||
| fi |
There was a problem hiding this comment.
We can simplify the render_timeout_command function by avoiding running command -v twice for each command check. Instead, we can directly output the command name once the check succeeds.
| if command -v timeout > /dev/null 2>&1; then | |
| command -v timeout | |
| return 0 | |
| fi | |
| if command -v gtimeout > /dev/null 2>&1; then | |
| command -v gtimeout | |
| return 0 | |
| fi | |
| if command -v timeout > /dev/null 2>&1; then | |
| echo "timeout" | |
| return 0 | |
| fi | |
| if command -v gtimeout > /dev/null 2>&1; then | |
| echo "gtimeout" | |
| return 0 | |
| fi |
1 participant
…embership walking.
No-rect clusters are now transparent, so descendants fall back to the nearest rendered ancestor. Implemented a CI hang guard.