Channel description is searched for the string "fgcom-mumble enabled" to see if it should enable the plugin#54
Draft
hbeni wants to merge 1 commit into
Draft
Channel description is searched for the string "fgcom-mumble enabled" to see if it should enable the plugin#54hbeni wants to merge 1 commit into
hbeni wants to merge 1 commit into
Conversation
hbeni
added
enhancement
hbeni
force-pushed
the
magicChannelDescriptions
branch
from
October 22, 2020 06:41
adfae7a to
312f927
Compare
hbeni
force-pushed
the
magicChannelDescriptions
branch
3 times, most recently
from
December 9, 2020 15:13
5141fa3 to
e0a4987
Compare
… to see if it should enable the plugin
/!\ BEWARE: this is notorious unstable, because mumble does only sync channel comments <128 bytes currently.
Longer comments will only be synched on-demand (when the users hovers over the channel), which
is too late for plugin initialization.
hbeni
force-pushed
the
magicChannelDescriptions
branch
from
December 9, 2020 15:21
e0a4987 to
e00289b
Compare
hbeni
marked this pull request as draft
February 11, 2021 10:34
hbeni
force-pushed
the
master
branch
3 times, most recently
from
May 18, 2021 14:38
c4de535 to
fe74a79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the feature that channels can be declared "FGCom-mumble enabled" by having a string
fgcom-mumble enabled(case-ignore) in the channel description.Longer comments will only be synched on-demand (when the users hovers over the channel), which
is too late for plugin initialization.
🚫 this is a hard road block in my eyes. We shouldn't merge this until mumble supplies an API function to force-download the text portion of the channel descriptions, or is at least configurable or forceable from the plugin side.
mumble://link, he must hover with the mouse over the channel to join. Which will sync the channel description, and on the actual join the plugin check will be positive.