Repository navigation
Bump Bun to 1.4.4 and cover the branches its coverage exposes - #411
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the
 |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
5329f69 to
1e753f9
Compare
|
Rebuilt to move the whole toolchain to Bun 1.4.4 so |
Move the whole toolchain together so bun-types matches the Bun that runs it: packageManager, every setup-bun pin in CI (deploy and release read packageManager), bun-types, and CONTRIBUTING's minimum. The guides that record the Bun they were tested on keep their 1.4.2 notes.
Bun 1.4.2 counted an unexecuted `continue`, a ternary's untaken arm on its own line, and some catch bodies as covered; 1.4.4 reports them, which left 85 never-run lines across 44 files under the per-file 100% gate. Add tests that drive each reachable branch through the module's exports. Remove the ones no input can reach, keeping behavior the same: - network/external audit checks: `probeAll` returns a result for every URL it was given, so the missing-result guards go (SAFETY casts, as the redirect loop already does). - `deployment` and `lastModified` schema errors: each union only raises the issues its message already covers, so the callbacks become strings. - config load: a failed parse always yields a diagnostic, so the "Invalid Blume config." fallback goes. - component override resolution: a folder whose `index` exists already passes the `existsSync` check above the index probe. - runtime navigation: with i18n the graph already holds one tree per configured locale, so the empty-tree fallback goes. - link scanning, api-rail attributes, and package-command rendering: the regex groups, parser attribute names, and command tables those guards checked are always present.
1e753f9 to
243e49d
Compare
haydenbleasel
changed the title
|
Bun 1.4.4 reports lines that 1.4.2 counted as covered (an unexecuted |
Its config imports blume/reference, which a fresh bun process on a cold windows-latest runner takes 12-16s to load on both Bun 1.4.2 and 1.4.4 (probed with a throwaway workflow); the suite's warm caches hid that on 1.4.2. Use the 30s timeout the other CLI-spawning tests already use.
Bumps bun-types from 1.4.2 to 1.4.4.
Release notes
Sourced from bun-types's releases.
... (truncated)
Commits
a950fc5Hardening follow-up: fix regressions from #46021 and more crashes (#46270)9b4284fHardening: fix crashes across the runtime, bundler, dev server, shell and CLI...3880151MoveCrypto,TextDecoder,Bun.FileSystemRouterand three more classes t...5667cd6sql: fixes for problems found after the consolidation (#45304) (#45711)d0831bcCheck published types against the bindgen schemas, honormemLeveland `stra...017b243sql: consolidate the open Bun.sql, bun:sqlite and node:sqlite pull requests (...f0c6cbcWebSocket: real closing handshake, one failure path,wsrewritten on native...21620e2Define eighteen Bun.* functions with the bindgen (#45450)e6f65f3install: fix regressions and older bugs found after the package manager conso...9510e74install: consolidate the open package manager pull requests (#44968)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)