Skip to content

AWS S3 (Setup Amazon S3 )<Ticket #59>#80

Open
ashrafcoding wants to merge 2 commits into
edit-profilefrom
aws-branch
Open

AWS S3 (Setup Amazon S3 )<Ticket #59>#80
ashrafcoding wants to merge 2 commits into
edit-profilefrom
aws-branch

Conversation

@ashrafcoding

Copy link
Copy Markdown
Collaborator

What this PR does (required):

  • Setup Amazon S3 and review uploadController file

Any information needed to test this feature (required):

  • need UI to test the upload of images to was s3

@ashrafcoding ashrafcoding changed the base branch from main to integrate September 23, 2021 19:25
@ashrafcoding ashrafcoding changed the base branch from integrate to edit-profile September 23, 2021 19:26

@sundayezeilo sundayezeilo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please link your ticket in your PR so I can understand how to best support you?

Comment thread server/controllers/uploadController.js Outdated
Comment thread server/controllers/uploadController.js Outdated
Comment thread server/controllers/uploadController.js Outdated
Comment thread server/controllers/uploadController.js Outdated
Comment thread server/routes/profileRouter.js Outdated
@rajivtitus

Copy link
Copy Markdown
Contributor

Hey @ashrafcoding, please refer to the below article to refactor your code (where necessary) and test the route using Postman.

Ref: https://newbedev.com/uploading-image-to-amazon-s3-using-multer-s3-nodejs

@ashrafcoding ashrafcoding changed the base branch from edit-profile to cont-profile-ashraf September 26, 2021 14:53
@ashrafcoding ashrafcoding changed the base branch from cont-profile-ashraf to edit-profile September 26, 2021 14:57
@ashrafcoding ashrafcoding changed the base branch from edit-profile to main September 29, 2021 12:59
@ashrafcoding ashrafcoding changed the base branch from main to edit-profile September 29, 2021 12:59

@rajivtitus rajivtitus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for a start!

@rajivtitus

Copy link
Copy Markdown
Contributor

@ashrafcoding Can we please merge this branch? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants