docs: Document ULOOP_PROJECT_RUNNER_PATH project runner override#1946
Merged
Conversation
The env var lets dogfooding checkouts run a locally built project runner instead of the pin-resolved release (whose stamped version 404s until the matching GitHub release exists), but nothing in the repo documented it. Add a section to docs/project-runner-pin.md and a pointer from the Native Go CLI Validation section of AGENTS.md.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughDocuments ChangesLocal project-runner override
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ULOOP_PROJECT_RUNNER_PATH(defined incli/dispatcher/internal/nativepath/path.go, consumed first inresolveDispatcherRealCLI) lets the dispatcher run a locally built project runner instead of resolving one from the pin. It is essential for dogfooding checkouts — release-please stampsprojectRunnerVersionahead of the published GitHub release, so the normal download path 404s — yet no document in the repository mentioned it.Changes
docs/project-runner-pin.md: new "Local override:ULOOP_PROJECT_RUNNER_PATH" section describing precedence (checked before pin validation, sibling binary, cache, and download), the executable-file requirement, the dogfooding rationale, and the siblingULOOP_INSTALL_DIR/ULOOP_CACHE_DIRoverrides.AGENTS.md(Native Go CLI Validation): one-paragraph pointer for validating unreleased Go changes from an external Unity project.Docs-only change; no code, scripts, or shared release inputs touched.