-
-
Notifications
You must be signed in to change notification settings - Fork 44
chore: Add Unity 6000.5 package compile compatibility check #1840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0387ec4
Add Unity 6000.5 compile compatibility check
hatayama f8fb74e
Fix Unity 6000.5 object identifier compatibility
hatayama 1a63e2d
Fix Unity 6000.5 adapter assembly visibility
hatayama 7f1b35e
Handle destroyed Unity objects in identifier adapter
hatayama 0dab8e4
Use raw EntityId value for Unity 6000.5
hatayama ac0576c
Handle Unity 6000.5 obsolete API diagnostics
hatayama 4adfc24
Use raw EntityId bits for compatibility handles
hatayama 7721cd5
Clear remaining Unity 6000.5 compiler warnings
hatayama 2d9a156
Validate Unity package assemblies when logs are unavailable
hatayama 7517f01
Fail Unity 6000.5 checks without compiler logs
hatayama 82e1506
Preserve Unity compiler log output
hatayama 9596aba
Pass Unity log path as separate arguments
hatayama 5b5469f
Write Unity logs outside build artifacts
hatayama 21fe66e
Capture compiler diagnostics from Unity job logs
hatayama db5dcbe
Compile Unity 6000.5 directly for diagnostics
hatayama caac8e1
Separate Unity compile execution modes
hatayama c496d2e
Use explicit matrix compile mode conditions
hatayama a69cce5
Reuse matrix unit test leg for editor selection
hatayama 97c8dc7
Match compile steps by Unity version
hatayama 1a3586f
Pass Unity license file explicitly
hatayama 2eb645a
Expose Unity logs when package compilation evidence is missing
hatayama 362623e
Activate Unity 6000.5 with a derived serial
hatayama d41e666
Use the fixture for Unity license activation
hatayama 5a3d83a
Avoid duplicate zero counts in compiler diagnostics
hatayama 65e62e4
Isolate Unity license activation from fixture compilation
hatayama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
Packages/src/Editor/ToolContracts/UnityObjectIdentifier.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| using UnityEngine; | ||
|
|
||
| namespace io.github.hatayama.UnityCliLoop.ToolContracts | ||
| { | ||
| /// <summary> | ||
| /// Provides the integer object handle required by the current pause-point response contract. | ||
| /// </summary> | ||
| internal static class UnityObjectIdentifier | ||
| { | ||
| /// <summary> | ||
| /// Gets an object handle while keeping the existing integer response contract compatible with older Unity versions. | ||
| /// </summary> | ||
| public static int GetInstanceId(Object unityObject) | ||
| { | ||
| Debug.Assert(unityObject is not null, "unityObject must not be null."); | ||
| #if UNITY_6000_4_OR_NEWER | ||
| // The wire contract remains int, so extract the same lower 32 bits as Unity's obsolete int cast. | ||
| // Unity 6000.5 stores a version marker in the upper 32 bits; future IDs may collide in this int shape. | ||
| return unchecked((int)EntityId.ToULong(unityObject.GetEntityId())); | ||
| #else | ||
| return unityObject.GetInstanceID(); | ||
| #endif | ||
| } | ||
| } | ||
| } |
2 changes: 2 additions & 0 deletions
2
Packages/src/Editor/ToolContracts/UnityObjectIdentifier.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| { | ||
| "dependencies": { | ||
| "io.github.hatayama.uloopmcp": "file:../../../../Packages/src" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| m_EditorVersion: 6000.5.4f1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.