Skip to content

fix: Setup falls back to skill target selection when folders are missing#1839

Merged
hatayama merged 1 commit into
v3-betafrom
fix/setup-wizard-skills-fallback-dropdown
Jul 19, 2026
Merged

fix: Setup falls back to skill target selection when folders are missing#1839
hatayama merged 1 commit into
v3-betafrom
fix/setup-wizard-skills-fallback-dropdown

Conversation

@hatayama

@hatayama hatayama commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • Setup Wizard can install skills even when no existing skill folders are detected.
  • Returning users see the target dropdown fallback instead of a disabled dead end.

User Impact

  • When .claude/, .agents/, or other skill folders are absent, Step 2 now keeps Install Skills available.
  • Existing skill folders continue to use the multi-target status list.

Changes

  • Resolve the effective first-install UI mode from the detected installable target count.
  • Reuse the same mode resolution for rendering and skill installation.
  • Add coverage for first-install, empty-target fallback, and existing-target cases.

Verification

  • dist/darwin-arm64/uloop compile --project-path "$(git rev-parse --show-toplevel)" — passed with 0 errors and 0 warnings.
  • dist/darwin-arm64/uloop run-tests --project-path "$(git rev-parse --show-toplevel)" --filter-type exact --filter-value 'io.github.hatayama.UnityCliLoop.Tests.Editor.SetupWizardWindowTests.ResolveUseFirstInstallSkillsUi_ReturnsExpectedMode' — 3/3 passed.
  • Full EditMode suite completed with two pre-existing unrelated failures in schema metadata and mouse UI pointer resolution tests.

Review in cubic

Use the first-install target UI when no existing skill folders are detected, and share the resolved mode with the install workflow so the enabled button creates the selected folder.
@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e2bd15ba-88c0-4f56-a979-cc52d4c9734d

📥 Commits

Reviewing files that changed from the base of the PR and between c7c650e and 7f6aa75.

📒 Files selected for processing (3)
  • Assets/Tests/Editor/SetupWizardWindowTests.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardSkillsStepPresenter.cs
  • Packages/src/Editor/Presentation/Setup/SetupWizardSkillsWorkflowController.cs

📝 Walkthrough

Walkthrough

The skills setup flow now resolves first-install UI mode from the filtered installable target count, updates presenter visibility and status handling, and applies the same resolution when selecting targets for installation. NUnit coverage verifies empty and non-empty target scenarios.

Changes

Skills UI Resolution

Layer / File(s) Summary
Resolve presenter UI mode
Packages/src/Editor/Presentation/Setup/SetupWizardSkillsStepPresenter.cs, Assets/Tests/Editor/SetupWizardWindowTests.cs
Update reuses filtered installable targets, resolves first-install mode when no targets are available, removes the empty-target early return, and adds parameterized resolver tests.
Wire workflow target selection
Packages/src/Editor/Presentation/Setup/SetupWizardSkillsWorkflowController.cs
HandleInstallSkillsAsync uses the filtered target count to choose between first-install target derivation and the filtered target list.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: Setup now falls back when skill folders are missing.
Description check ✅ Passed The description is clearly related to the changeset and matches the fallback behavior implemented in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/setup-wizard-skills-fallback-dropdown

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 7deb9d2 into v3-beta Jul 19, 2026
10 checks passed
@hatayama
hatayama deleted the fix/setup-wizard-skills-fallback-dropdown branch July 19, 2026 05:27
@github-actions github-actions Bot mentioned this pull request Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant