fix: resolve macOS E2E failures#1834
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe PR adds a ChangesGame View resolution tool
Roslyn compiler options
Smoke-test updates
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/RoslynCompilerOptions.cs`:
- Around line 22-25: Replace the null-check exception in the
RoslynCompilerOptions constructor with a Debug.Assert using the specified
defineSymbols message, and add the UnityEngine import required for it. In
Assets/Tests/Editor/DynamicCodeToolTests/RoslynCompilerOptionsTests.cs lines
50-59, delete Constructor_WithNullDefineSymbols_ThrowsArgumentNullException
because this precondition is now enforced by assertion rather than a runtime
exception.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 93774b10-48b8-4a23-a552-2ed8eec5ac14
⛔ Files ignored due to path filters (11)
Assets/Tests/Editor/DynamicCodeToolTests/RoslynCompilerOptionsTests.cs.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/RoslynCompilerOptions.cs.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeResponse.cs.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeSchema.cs.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeTool.cs.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeUseCase.cs.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/Skill.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/Skill/SKILL.md.metais excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/UnityCLILoop.FirstPartyTools.SetGameViewSize.Editor.asmdefis excluded by none and included by nonePackages/src/Editor/FirstPartyTools/SetGameViewSize/UnityCLILoop.FirstPartyTools.SetGameViewSize.Editor.asmdef.metais excluded by none and included by none
📒 Files selected for processing (20)
.agents/skills/uloop-set-game-view-size/SKILL.md.claude/skills/uloop-set-game-view-size/SKILL.mdAssets/Tests/Demo/scripts/verify-replay-via-cli.shAssets/Tests/Editor/DynamicCodeToolTests/ExternalCompilerPathResolverTests.csAssets/Tests/Editor/DynamicCodeToolTests/RoslynCompilerOptionsTests.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Compilation/ICompiledAssemblyBuilder.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/CompiledAssemblyBuilder.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCodeCompiler.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/DynamicCompilationBackend.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/RoslynCompilerBackend.csPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/DynamicCompilation/RoslynCompilerOptions.csPackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeResponse.csPackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeSchema.csPackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeTool.csPackages/src/Editor/FirstPartyTools/SetGameViewSize/SetGameViewSizeUseCase.csPackages/src/Editor/FirstPartyTools/SetGameViewSize/Skill/SKILL.mdcli/common/tools/default-tools.jsonscripts/smoke-cli-recovery-readiness.goscripts/test-simulate-mouse-demo.shscripts/test-smoke-cli-recovery-readiness.sh
Treat the compiler options snapshot as an internal contract: the only producer normalizes null define symbols before construction. Use the project's assertion convention for that programmer error and keep the remaining tests focused on snapshot behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
set-game-view-sizefirst-party tool and replace reflection-based Game View handling in the mouse E2E script.Verification
sh scripts/run-posix-e2e.shpassed twice consecutively onfix/macos-e2e-integration.RESULT: MATCH (11 events identical),RESULT: PASS, andAll POSIX terminal-driven E2E checks passed.