fix: remove invalid recovery-target release path#1822
Conversation
Always target the approved event commit so each publish run can produce attestations that match its release tag. Remove the obsolete historical-release recovery flow and point authorization failures to the roll-forward runbook.
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe native CLI release flow now uses the approved event commit as its only release target. Recovery-target dispatch and legacy target resolution are removed, metadata validation is tightened, and release-creation 403 handling consistently reports roll-forward recovery guidance. ChangesNative CLI release publishing
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/release-recovery-runbook.md`:
- Around line 89-90: Remove or update the historical-resolver guidance in the
passages around lines 52-54 and 94-96 so the runbook consistently documents
event-head-only behavior. Ensure no remaining text claims the resolver can
target or publish a historical commit, while preserving the surrounding recovery
instructions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 15a749f4-509e-4fe3-9443-003b504b8850
📒 Files selected for processing (5)
.github/workflows/native-cli-publish.ymldocs/release-recovery-runbook.mdscripts/resolve-native-cli-release-target.shscripts/test-native-cli-publish-workflow.shscripts/test-resolve-native-cli-release-target.sh
Remove obsolete historical-resolver behavior from the recovery runbook after deleting the recovery-target mode.
Keep the three publish-stage release tag SHA checks covered while removing the recovery-target-specific tests.
f4d2087
into
feature/release-pipeline-hardening-integration
Summary
Removes the obsolete
recovery-targetpublish mode. Every publish now resolves to the approved event-head commit, so a run cannot create assets whose attestation digest differs from the release tag.It also removes the historical-release resolver path and recovery-only tests, and replaces the old owner-assisted 403 guidance with the roll-forward runbook.
Verification
C:\\Program Files\\Git\\bin\\bash.exe scripts/test-resolve-native-cli-release-target.shC:\\Program Files\\Git\\bin\\bash.exe scripts/test-native-cli-publish-workflow.sh.github/workflows/native-cli-publish.ymlgit diff --checkNormal GitHub Actions CI does not run for pull requests targeting the integration branch.