Skip to content

fix: make Windows v3 workflows reliable#1818

Merged
hatayama merged 6 commits into
v3-betafrom
feature/windows-v3-verification-integration
Jul 17, 2026
Merged

fix: make Windows v3 workflows reliable#1818
hatayama merged 6 commits into
v3-betafrom
feature/windows-v3-verification-integration

Conversation

@hatayama

@hatayama hatayama commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Make Windows input simulation, self-update, process discovery, and window focus workflows reliable.
  • Run all CLI Go modules in Windows CI and make their test fixtures portable.
  • Prevent recovery-target release dispatches from publishing unverifiable assets.

User Impact

  • Windows users can update a running CLI, use projects with non-ASCII paths, and receive an honest focus result.
  • Input simulation no longer loses a successful response while restoring background execution.

Changes

  • Merge the six reviewed Windows verification fixes from the integration branch.
  • Expand the Windows workflow to exercise common, dispatcher, project-runner, and release-automation Go modules.

Verification

  • Integration PR checks: runs 29541583361, 29578234174, 29578556155, 29578557463, 29578558871, and 29578560261 all completed successfully.
  • Validation results are recorded in the 2026-07-17 Windows verification results note.

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 584df1b3-f3eb-446d-afad-2baea3b8cb28

📥 Commits

Reviewing files that changed from the base of the PR and between b42f918 and 4b18d53.

⛔ Files ignored due to path filters (5)
  • Packages/src/Editor/FirstPartyTools/Common/InputSimulation/UnityCLILoop.FirstPartyTools.Common.InputSimulation.Editor.asmdef is excluded by none and included by none
  • cli/common/unityprocess/focus_unity_process.ps1 is excluded by none and included by none
  • cli/common/unityprocess/focus_unity_process_with_restore.ps1 is excluded by none and included by none
  • cli/project-runner/go.mod is excluded by none and included by none
  • scripts/install.ps1 is excluded by none and included by none
📒 Files selected for processing (23)
  • .github/workflows/build-and-test.yml
  • .github/workflows/native-cli-publish.yml
  • Packages/src/Editor/FirstPartyTools/Common/InputSimulation/InputSimulationRunInBackgroundScope.cs
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/SimulateKeyboardUseCase.cs
  • Packages/src/Editor/FirstPartyTools/SimulateMouseInput/SimulateMouseInputUseCase.cs
  • cli/common/unityprocess/command_error.go
  • cli/common/unityprocess/command_error_test.go
  • cli/common/unityprocess/focus_windows.go
  • cli/common/unityprocess/process.go
  • cli/common/unityprocess/process_test.go
  • cli/dispatcher/internal/dispatcher/launch_test.go
  • cli/dispatcher/internal/install/command_test.go
  • cli/project-runner/internal/projectrunner/control_play_mode_wait_test.go
  • cli/project-runner/internal/projectrunner/ipc_listener_fixture_unix_test.go
  • cli/project-runner/internal/projectrunner/ipc_listener_fixture_windows_test.go
  • cli/release-automation/internal/automation/contract_file_at_ref_test.go
  • cli/release-automation/internal/automation/dispatcher_minimum_version_guard_test.go
  • cli/release-automation/internal/automation/mock_cli_executable_for_tests_test.go
  • cli/release-automation/internal/automation/mock_git_for_tests_test.go
  • cli/release-automation/internal/automation/protocol_minimum_version_guard_test.go
  • cli/release-automation/internal/automation/testdata/mockcli/main.go
  • docs/release-recovery-runbook.md
  • scripts/test-native-cli-publish-workflow.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/windows-v3-verification-integration

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit 21eae0a into v3-beta Jul 17, 2026
10 checks passed
@hatayama
hatayama deleted the feature/windows-v3-verification-integration branch July 17, 2026 12:21
@github-actions github-actions Bot mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant