Skip to content

fix: V2 delegation now recognizes SCP Git dependencies with path queries#1811

Merged
hatayama merged 1 commit into
v3-betafrom
fix/v2-git-scp-path-query
Jul 16, 2026
Merged

fix: V2 delegation now recognizes SCP Git dependencies with path queries#1811
hatayama merged 1 commit into
v3-betafrom
fix/v2-git-scp-path-query

Conversation

@hatayama

@hatayama hatayama commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Recognize Unity SCP-style Git dependencies that include a ?path= query when resolving lockless V2 projects.

User Impact

  • V2 delegation no longer falls back to the pin path solely because an SCP Git dependency selects a package subdirectory.
  • HTTPS Git dependencies with path queries remain supported.

Changes

  • Remove the query segment before validating Git dependency suffixes.
  • Add regression coverage for SCP and HTTPS Git URLs with path queries.

Verification

  • go test ./internal/dispatcher -run TestIsDispatcherGitPackageDependencyAcceptsPathQueries -count=1
  • go test ./internal/dispatcher -run "TestIsDispatcherGitPackageDependency|TestDetectV2DispatcherProject" -count=1
  • go clean -testcache
  • scripts/check-go-cli.sh

Review in cubic

Strip Unity package path queries before checking SCP-style Git dependency
suffixes so lockless V2 projects remain eligible for safe cache fallback.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 9 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 308d2ca1-6f59-446c-971c-692432607e53

📥 Commits

Reviewing files that changed from the base of the PR and between 3882b19 and b45ff8b.

📒 Files selected for processing (2)
  • cli/dispatcher/internal/dispatcher/dispatcher_v2_detect.go
  • cli/dispatcher/internal/dispatcher/dispatcher_v2_detect_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/v2-git-scp-path-query

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit b42f918 into v3-beta Jul 16, 2026
9 checks passed
@hatayama
hatayama deleted the fix/v2-git-scp-path-query branch July 16, 2026 10:24
@github-actions github-actions Bot mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant