Skip to content

fix: Project commands now work from paths containing glob characters#1810

Merged
hatayama merged 1 commit into
v3-betafrom
fix/dispatcher-pin-literal-package-cache
Jul 16, 2026
Merged

fix: Project commands now work from paths containing glob characters#1810
hatayama merged 1 commit into
v3-betafrom
fix/dispatcher-pin-literal-package-cache

Conversation

@hatayama

@hatayama hatayama commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Summary

  • Ensure V3 project-runner pins are discovered when a Unity project path contains glob metacharacters such as brackets.

User Impact

  • Project-scoped commands no longer report a missing runner pin solely because the project path contains [ or ].

Changes

  • Replace glob-based PackageCache pin discovery with literal directory traversal.
  • Preserve package directory filtering and candidate ordering.
  • Add regression coverage for a bracketed project path.

Verification

  • go test ./internal/dispatcher -run TestLoadDispatcherPinFindsPackageCachePinWithBracketedProjectPath -count=1
  • go test ./internal/dispatcher -run TestLoadDispatcherPin -count=1
  • go clean -testcache
  • scripts/check-go-cli.sh

Closes #1808

Review in cubic

Replace glob-based PackageCache discovery with directory traversal so project
paths containing pattern metacharacters cannot hide valid project-runner pins.
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8fc11e79-71ee-4492-aa56-d063a1b9d3ab

📥 Commits

Reviewing files that changed from the base of the PR and between 3882b19 and 6bb86a8.

📒 Files selected for processing (2)
  • cli/dispatcher/internal/dispatcher/dispatcher_pin.go
  • cli/dispatcher/internal/dispatcher/dispatcher_test.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dispatcher-pin-literal-package-cache

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama
hatayama merged commit c56843a into v3-beta Jul 16, 2026
9 checks passed
@hatayama
hatayama deleted the fix/dispatcher-pin-literal-package-cache branch July 16, 2026 10:24
@github-actions github-actions Bot mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant