Skip to content

fix: Improve CLI PlayMode reliability for background input simulation#1714

Merged
hatayama merged 2 commits into
v3-betafrom
feat/input-simulation-reliability
Jul 12, 2026
Merged

fix: Improve CLI PlayMode reliability for background input simulation#1714
hatayama merged 2 commits into
v3-betafrom
feat/input-simulation-reliability

Conversation

@hatayama

@hatayama hatayama commented Jul 12, 2026

Copy link
Copy Markdown
Owner

Refs: 2026-07-12_uloop検証フィードバック改善 実装計画.md#Group 1

Summary

  • CLI-started PlayMode keeps advancing while Unity is unfocused (Application.runInBackground).
  • Simulated keyboard presses hold until gameplay can observe wasPressedThisFrame (bounded).

Child PRs

User Impact

  • Time-dependent E2E between CLI commands no longer depends on Unity staying focused after control-play-mode Play.
  • Short key presses are less likely to miss gameplay when frames are tight or focus is lost.

Verification

  • Local compile 0/0 and pure EditMode tests green for both child PRs
  • Real Editor checks for runInBackground save/restore and Press smoke
  • Fable 5 final review LGTM on both child PRs

Protocol

  • No protocol version bump (additive response fields / behavior only)

Review in cubic

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f19ce6b4-598a-470e-a15d-f2c863462d3c

📥 Commits

Reviewing files that changed from the base of the PR and between a6eff6e and 31a0a37.

⛔ Files ignored due to path filters (6)
  • Assets/Tests/Editor/CliPlayModeRunInBackgroundControllerTests.cs.meta is excluded by none and included by none
  • Assets/Tests/Editor/PressHoldUntilEdgeLogicTests.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/PressHoldUntilEdgeLogic.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/CliPlayModeRunInBackgroundController.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/CliPlayModeRunInBackgroundService.cs.meta is excluded by none and included by none
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/CliPlayModeRunInBackgroundSessionStore.cs.meta is excluded by none and included by none
📒 Files selected for processing (11)
  • Assets/Tests/Editor/CliPlayModeRunInBackgroundControllerTests.cs
  • Assets/Tests/Editor/PressHoldUntilEdgeLogicTests.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/InputSystemUpdateHelper.cs
  • Packages/src/Editor/FirstPartyTools/Common/InputSystem/PressHoldUntilEdgeLogic.cs
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/CliPlayModeRunInBackgroundController.cs
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/CliPlayModeRunInBackgroundService.cs
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/CliPlayModeRunInBackgroundSessionStore.cs
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/ControlPlayModeServices.cs
  • Packages/src/Editor/FirstPartyTools/ControlPlayMode/ControlPlayModeUseCase.cs
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/KeyboardInputActionExecutor.cs
  • Packages/src/Editor/FirstPartyTools/SimulateKeyboard/SimulateKeyboardResponse.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/input-simulation-reliability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hatayama hatayama merged commit 8845709 into v3-beta Jul 12, 2026
10 checks passed
@hatayama hatayama deleted the feat/input-simulation-reliability branch July 12, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant