fix: Harden V2-to-V3 third-party migration for safe apply and reliable scans

[hatayama]

Summary

Landing the v3-migration-hardening integration branch into v3-beta as one squash commit. This hardens the V2→V3 third-party migration path across write safety, rewrite correctness, wizard UX, temporary skill guidance, Go skill install cleanup, and scan exclusions.

Included changes (PR1–PR9)

• PR1 (fix: Make third-party migration writes an all-or-nothing batch #1701): Make migration file writes an all-or-nothing batch with prepare/commit/rollback
• PR2 (fix: Preserve encoding and asmdef formatting during migration writes #1702): Preserve source encoding/BOM and edit asmdef references surgically
• PR3 (fix: Stop migration masking from treating directive apostrophes as chars #1703): Stop migration masking from treating directive apostrophes as char literals
• PR4 (fix: Guard contract type renames against local type shadowing #1704): Guard contract type renames against local type shadowing
• PR5 (fix: Make migration wizard auto-scan and async handlers reliable #1705): Make migration wizard auto-scan and async handlers reliable
• PR6 (fix: Confirm migration apply and list target files in the wizard #1706): Confirm migration apply and list target files before rewriting
• PR7 (fix: Expand temporary V3 migration skill removed-command guidance #1707): Expand temporary V3 migration skill removed-command and boolean guidance
• PR8 (fix: Clean alternate V3 migration skill layouts on skip #1708): Clean alternate V3 migration skill layouts when the preferred layout is already installed
• PR9 (fix: Harden migration scans against symlink cycles and ignored folders #1709): Harden migration scans against symlink/junction cycles and Unity-ignored folders

User Impact

Third-party migration is safer to run: failed applies roll back, encoding and asmdef formatting stay intact, the wizard asks before rewriting and shows which files change, and scans no longer hang on symlink cycles or dive into Unity-ignored folders.

Test plan

• GitHub Actions PR CI on v3-beta (Build and Test / Unity Compile Check) — final gate
• Local verification already completed per PR1–PR9 before integration merges
• Fable 5 final confirmation after CI is green

Made with Cursor

[coderabbitai]

Warning

Review limit reached

@hatayama, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 4 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: e39e871c-0f64-4a0a-bf9c-62e1d1ab99ad

📥 Commits

Reviewing files that changed from the base of the PR and between 8785326 and 76fa464.

⛔ Files ignored due to path filters (6)

• Assets/Tests/Editor/ThirdPartyToolMigrationAsmdefTextEditorTests.cs.meta is excluded by none and included by none
• Assets/Tests/Editor/ThirdPartyToolMigrationCodeTextMaskBuilderTests.cs.meta is excluded by none and included by none
• Assets/Tests/Editor/ThirdPartyToolMigrationFileWriterTests.cs.meta is excluded by none and included by none
• Assets/Tests/Editor/ThirdPartyToolMigrationLocalTypeShadowingTests.cs.meta is excluded by none and included by none
• Assets/Tests/Editor/ThirdPartyToolMigrationProjectFileInventoryTests.cs.meta is excluded by none and included by none
• Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationAsmdefTextEditor.cs.meta is excluded by none and included by none

📒 Files selected for processing (25)

• Assets/Tests/Editor/ThirdPartyToolMigrationAsmdefTextEditorTests.cs
• Assets/Tests/Editor/ThirdPartyToolMigrationCodeTextMaskBuilderTests.cs
• Assets/Tests/Editor/ThirdPartyToolMigrationFileWriterTests.cs
• Assets/Tests/Editor/ThirdPartyToolMigrationLocalTypeShadowingTests.cs
• Assets/Tests/Editor/ThirdPartyToolMigrationProjectFileInventoryTests.cs
• Assets/Tests/Editor/ThirdPartyToolMigrationRulesTests.cs
• Assets/Tests/Editor/ThirdPartyToolMigrationWizardWindowTests.cs
• Packages/src/Editor/Domain/ThirdPartyToolMigrationCSharpRules.cs
• Packages/src/Editor/Domain/ThirdPartyToolMigrationCodeTextMaskBuilder.cs
• Packages/src/Editor/Domain/ThirdPartyToolMigrationRuleCatalog.cs
• Packages/src/Editor/Domain/ThirdPartyToolMigrationSourceDetectionRules.cs
• Packages/src/Editor/Domain/ThirdPartyToolMigrationTypeReplacementRules.cs
• Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationAsmdefRules.cs
• Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationAsmdefTextEditor.cs
• Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationFileService.cs
• Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationFileWriter.cs
• Packages/src/Editor/Infrastructure/ThirdPartyToolMigration/ThirdPartyToolMigrationProjectFileInventory.cs
• Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardStateRules.cs
• Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardText.cs
• Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardView.cs
• Packages/src/Editor/Presentation/Setup/ThirdPartyToolMigrationWizardWindow.cs
• Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/SKILL.md
• Packages/src/TemporarySkills~/v3-cli-invocation-migration/Skill/references/first-party-v2-to-v3.md
• cli/dispatcher/internal/dispatcher/skills_test.go
• cli/dispatcher/internal/dispatcher/skills_v3_migration.go

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch v3-migration-hardening

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}