chore: upgrade dependencies - #35
Merged
Merged
Conversation
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several updates to dependencies, code style, and build configuration to modernize the project and improve maintainability. The main changes include upgrading to
ndc-sdk-go/v2, switching togoenvconffor environment variable handling, updating the base images in theDockerfile, and enhancing linting rules. Additionally, the release workflow for the forked repository has been removed.Dependency upgrades and code modernization:
ndc-sdk-gotondc-sdk-go/v2across the codebase, including all API, schema, and utility imports, to ensure compatibility with the latest SDK features and improvements. [1] [2] [3] [4] [5]utils.NewEnvStringValuewithgoenvconf.NewEnvStringValuefor environment variable configuration in both source and test files, and updated related types and test cases accordingly. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Build and release process:
Dockerfileto usegolang:1.26for building anddistroless/static-debian13:nonrootfor production, ensuring the project uses up-to-date base images. [1] [2].github/workflows/release-fork.yamlworkflow, discontinuing the fork-specific release automation.Linting and code style:
gomodguard,goconst,wsl) to.golangci.ymlto enforce stricter code quality and consistency.Minor code and documentation improvements:
README.mdto point to the v2 SDK.Other code enhancements:
strings.CutSuffixfor better clarity and correctness.gotel.NewTracerfor tracing in the client package. [1] [2]//nolint:goseccomment to a debug log line to suppress a specific linter warning.Overall, these changes bring the project up to date with the latest dependencies and best practices, improve code quality, and streamline the build and release process.