Rename the addons and addon_configs Taildrive shares to local_apps and app_configs to match Home Assistant's app terminology - config is automatically updated

[lmagyar]

Proposed Changes

SSIA

Related Issues

Summary by CodeRabbit

• New Features

  • Updated Taildrive configuration options to use local_apps and app_configs.
  • Added automatic migration of existing addons and addon_configs settings to the new names.

• Bug Fixes

  • Improved Taildrive cleanup to recognize and remove shares using deprecated configuration names.
  • Ensured managed shares are cleaned up before current shares are published.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0e2320a6-1104-4c26-b2ef-cb6057cfddb0

📥 Commits

Reviewing files that changed from the base of the PR and between c70a62b and 11ac432.

📒 Files selected for processing (1)

• tailscale/rootfs/etc/s6-overlay/s6-rc.d/taildrive/run

🚧 Files skipped from review as they are similar to previous changes (1)

• tailscale/rootfs/etc/s6-overlay/s6-rc.d/taildrive/run

---

Walkthrough

Taildrive configuration now uses local_apps and app_configs instead of addons and addon_configs. Stage 2 migrates legacy settings. Taildrive cleanup recognizes deprecated directory names and synchronizes configured shares after removing stale shares.

Changes

Taildrive naming migration

Layer / File(s)	Summary
Taildrive configuration contract tailscale/config.yaml, tailscale/DOCS.md	Mappings, options, schema validation, and documentation use local_apps and app_configs.
Legacy configuration migration tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh	Stage 2 detects legacy taildrive.addons, renames keys to local_apps and app_configs, removes old keys, and saves the transformed configuration.
Share cleanup and synchronization tailscale/rootfs/etc/s6-overlay/s6-rc.d/taildrive/run	Cleanup includes deprecated directory names. Configured shares synchronize after stale shares are unshared.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• hassio-addons/app-tailscale#617: Introduced the Taildrive configuration and behavior that this PR migrates and maintains.

Suggested labels: maintenance

Suggested reviewers: frenck

Poem

A rabbit once roamed through the drive,
Where local_apps help paths thrive.
Old addon names fade,
As migrations parade,
Fresh configs keep Taildrive alive.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: renaming Taildrive configuration options from addons/addon_configs to local_apps/app_configs, including the rationale and automatic migration behavior.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[lmagyar]

To fix the linter issue, see: frenck/action-addon-linter#234

[coderabbitai]

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

putComment timed out

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tailscale/rootfs/etc/s6-overlay/s6-rc.d/taildrive/run`:
- Around line 17-18: Ensure the command substitution assigning all_share_names
preserves and propagates a failed jq parse instead of allowing the trailing
printf to mask its status. Update the taildrive run script so the deprecated
names are appended only after bashio::config and jq succeed, while retaining the
existing names in successful results.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9eb436c1-642d-4173-affe-b7f320508c65

📥 Commits

Reviewing files that changed from the base of the PR and between efcbe9c and c70a62b.

📒 Files selected for processing (4)

• tailscale/DOCS.md
• tailscale/config.yaml
• tailscale/rootfs/etc/s6-overlay/s6-rc.d/taildrive/run
• tailscale/rootfs/etc/s6-overlay/scripts/stage2_hook.sh