Add diagonal corner lines for better visibility - #1
Open
kanawanaikoto wants to merge 1 commit into
Open
Conversation
To make the invalid redundant code meaningful
hassanrrraza
left a comment
Owner
There was a problem hiding this comment.
Thank you for the contribution!
However, this version introduces arbitrary +2 and -2 offsets, which may cause the corner lines to look misaligned, especially on smaller bounding boxes. It also adds unnecessary complexity to otherwise clean and precise drawing logic.
That said, this approach might be useful in specific cases, such as:
-Creating visual separation from the bounding box edges
-Applying anti-aliasing or avoiding overlap with other UI elements
-Performing pixel-level tuning for aesthetic reasons
Unless we have a strong visual requirement for such tweaks, I recommend keeping the original version for consistency and clarity.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Modify some function parameters to achieve this.
Original code appears to be invalid redundant code.
The deletion of the code above does not affect the realization of the original effect

Before
After

I have taken note of your comment and made some modifications.