Made build for Alpine possible [resolves #172]

[niekberenschot]

resolves #172

Overview

A high level description of the contribution, including:
Who the change affects or is for (stakeholders)?
What is the change?
Why is the change needed?
How does this change affect the user experience (if at all)?

Design of Change

How was this change implemented?

Related Issues/Pull Requests

[ ] Issue #1234
[ ] PR #1234

Contributor Checklist

[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[ ] Backwards compatible
[ ] Changelog entry added. See Updating the Changelog.

PCI review checklist

• I have documented a clear reason for, and description of, the change I am making.

• If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.

• If applicable, I've documented the impact of any changes to security controls.

  Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.

[fairclothjm]

Thanks for the PR @niekberenschot but unfortunately we can't accept it. go-ora does not support TNS aliasing so this change would be a regression.

[niekberenschot]

Thanks for the clarification! Since we’re blocked by the Kubernetes deployment and also need to think about failover servers, how would you like to proceed here? Can I help by creating a driver that supports TNS, or are you planning to take this on, @fairclothjm?

[fairclothjm]

@niekberenschot First, thanks for the offer to help! Unfortunately, we cannot accept the offer as we must ensure a stable experience for our current users. If we did decide to migrate to another driver it would most likely be godror which is built on top of the official Oracle ODPI-C library. However, we do not have plans to migrate from mattn/go-oci8 anytime soon.

If this is blocking you, then you have the option to fork this repo and use the driver of your choice.

[niekberenschot]

We’re one of the users (enterprise), and we’re also waiting for this to be built in with official support. Running and maintaining our own custom forks or hacks isn’t sustainable for us long term. Having this supported natively in Kubernetes would make adoption and maintenance much smoother across our teams.

[fairclothjm]

@niekberenschot Hello, I understand your concerns. I have shared your feedback internally. Full disclosure: we don't have any plans to make the oracle plugin built-in to the Vault binary.

[heatherezell]

We’re one of the users (enterprise), and we’re also waiting for this to be built in with official support. Running and maintaining our own custom forks or hacks isn’t sustainable for us long term. Having this supported natively in Kubernetes would make adoption and maintenance much smoother across our teams.

Hi there! Do you have an existing support case? I recommend opening a ticket with support to get the fastest response time. You can also contact your sales team in order to file a feature request. Please feel free to share the issue/PR IDs with them as well. Thanks! :)

[niekberenschot]

We’re one of the users (enterprise), and we’re also waiting for this to be built in with official support. Running and maintaining our own custom forks or hacks isn’t sustainable for us long term. Having this supported natively in Kubernetes would make adoption and maintenance much smoother across our teams.

Hi there! Do you have an existing support case? I recommend opening a ticket with support to get the fastest response time. You can also contact your sales team in order to file a feature request. Please feel free to share the issue/PR IDs with them as well. Thanks! :)

Yes, we do have tickets. 194834 for this Oracle driver. We are waiting for a fix.

[Shocktrooper]

@fairclothjm From what I was looking at TNS aliasing is supported in go-ora? But I am not 100% sure about that.
One thing I have noticed though is that https://github.com/sijms/go-ora is being continuously updated and the current library used in this https://github.com/mattn/go-oci8 has not been touched in 6 years. I suspect at some point something will not be forward compatible anymore and the library will have to be forked and fixed or replaced for this vault plugin to continue working.