Skip to content

feat(kv): include KV v2 metadata (custom_metadata, version) in read_secret #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
artfaal wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

feat(kv): include KV v2 metadata (custom_metadata, version) in read_secret #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/tools/kv/read_secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,13 @@ func readSecretHandler(ctx context.Context, req mcp.CallToolRequest, logger *log
if !ok {
return mcp.NewToolResultError("unexpected secret data format for v2 API"), nil
}
secretData = data
// Include the KV v2 metadata block (version, created/updated times and
// custom_metadata such as description/usage) alongside the data payload,
// instead of discarding it — clients need it to understand a secret.
secretData = map[string]interface{}{
"data": data,
"metadata": secret.Data["metadata"],
}
} else {
// V1 API structure: secret.Data directly contains the key-value pairs
secretData = secret.Data
Expand Down