This repository was archived by the owner on Jun 30, 2025. It is now read-only.
sort aliases before comparing#409
Open
fceller wants to merge 1 commit into
Open
Conversation
hoangmirs
approved these changes
Aug 11, 2023
|
Can we merge this PR? |
|
Implemented this for my fork: SamuZad@437bba9 https://registry.terraform.io/providers/SamuZad/googleworkspace/latest |
|
Update on this: this introduced a new (and imo quite annoying problem) - if one commented out the aliases attribute completely but the previous iteration had aliases, the plan would say "no changes" this is because the d.HasChange("aliases") would not be able to return the new value properly - hence SamuZad@cbc7086 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #360
In order to avoid changes on every run, first sort the aliases and then compare.