fix(issue-351): implementation#359
Conversation
to generate one" This reverts commit 2d02f12.
|
Creation Ok, but on next plan want to remove password, need to check that |
Maarc-D
changed the title
|
Creation Ok and no more change on next launch. everything ok with this implementation |
|
merge it |
|
Used since then, no issue. Do you have a release date in mind ? |
Co-authored-by: Ricardo Graça <81819036+ricardograca-scratch@users.noreply.github.com>
|
Hey @Maarc-D I'm just a regular user of this provider. I don't think me reviewing it will make any difference whether it's accepted or not. |
I gave it an attempt :p |
@appilon @SarahFrench @bflad @megan07 is it possible to review / merge it please ? ;) |
|
Would love to get this reviewed/merged in. |
can you try, maybe it will make it move next step :p |
|
I'm not a go developer and also it explicitly says "Code owner review required", and I'm not a code owner, but I'll try to get some traction on this issue. |
I know but you seems to be "requested for review" and I cannot change or remove that :/ |
ricardograca-scratch
left a comment
ricardograca-scratch
left a comment
There was a problem hiding this comment.
Looks good to me, but I'm not a Go developer nor a maintainer of this project, so I'm only writing this because there doesn't seem to be a way to not provide a review after having been added as a reviewer 🤷
4 participants
Description
Related to #351