Remove dead repo link and change descriptions that referred to Vault … - #5
Remove dead repo link and change descriptions that referred to Vault …#5blaisep wants to merge 1 commit into
Conversation
…instead of Nomad (to reduce confusion). Changes to be committed: modified: examples/nomad-consul-separate-cluster/main.tf modified: examples/nomad-consul-separate-cluster/variables.tf modified: variables.tf
|
@josh-padnick Here are some small corrections to make things run more smoothly for noobs (like me). |
josh-padnick
left a comment
josh-padnick
left a comment
There was a problem hiding this comment.
Thank you for this PR! One simple change and then we're ready to merge.
|
|
||
| module "consul_cluster" { | ||
| source = "git::git@github.com:gruntwork-io/terraform-google-consul.git//modules/consul-cluster?ref=v0.0.2" | ||
| source = "git::git@github.com:hashicorp/terraform-google-consul.git/modules/consul-cluster" |
There was a problem hiding this comment.
It's very important that we include a ?ref=vX.Y.Z here. Otherwise, each invocation of this module will download what is then the latest commit to the master branch. As of today, the latest release of https://github.com/hashicorp/terraform-google-consul is v0.0.3, so can you update accordingly?
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
3 participants
…instead of Nomad (to reduce confusion).
Changes to be committed:
modified: examples/nomad-consul-separate-cluster/main.tf
modified: examples/nomad-consul-separate-cluster/variables.tf
modified: variables.tf