This repository was archived by the owner on Jan 25, 2023. It is now read-only.
upgrade ubuntu & consul module versions - #21
Open
krantzinator wants to merge 1 commit into
Open
Conversation
krantzinator
requested review from
josh-padnick and
robmorgan
as code owners
November 15, 2021 17:24
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I attempted to pull this repo in line with the terraform-google-consul module's repo. I also updated the ubuntu images to 18.04/20.04 (up from 16.04/18.04). Preliminary tests seem good, but definitely open to suggestions for in-depth testing, or feedback as to why these updates have been put off so far.
Also FYI the link in the README for CONTRIBUTING.md is broken (https://github.com/hashicorp/terraform-google-nomad/tree/master/CONTRIBUTING.md), so also let me know if a PR needs a specific format.
Edit: Ah, I see the PR templates are in progress! 🙌🏻