This repository was archived by the owner on Jan 25, 2023. It is now read-only.
Add app version for GC Region Instance Group Manager - #49
Closed
naiduarvind wants to merge 1 commit into
Closed
Conversation
Signed-off-by: naiduarvind <arvind.naidu@mindvalley.com>
|
|
Author
|
@josh-padnick @robmorgan - let's have this reviewed quickly and merged since it is quite simple a one-liner change. |
This was referenced May 22, 2020
Author
|
@josh-padnick @robmorgan what is status on reviewing this pull request? |
|
The nomad module has the same issue. PR outstanding and un-merged / unloved. |
|
Any reason/blocker this hasn't been merged yet? Seems like a simple enough change that doesn't appear to break anything else. |
Collaborator
|
Closing this PR in favor of #55. We are going to take advantage of TF 0.12 and no longer use the |
naiduarvind
deleted the
add-app-version-for-gc-region-instance-group-manager
branch
September 15, 2020 17:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: naiduarvind arvind.naidu@mindvalley.com
Without the version attribute present,
terraform planwas not working as expected when deploying Vault referencing this module for Consul. Having this attribute for Vault fixed it hence creating this PR to ensure consistency for Consul - being the dependency module.