security/SAML: fix InResponseTo request-correlation bypass - #192
Open
pkazmierczak wants to merge 2 commits into
Open
security/SAML: fix InResponseTo request-correlation bypass#192pkazmierczak wants to merge 2 commits into
InResponseTo request-correlation bypass#192pkazmierczak wants to merge 2 commits into
Conversation
pkazmierczak
changed the title
InResponseTo request-correlation bypass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset fixes a security vulnerability that allowed fresh SAML requests
to use old request ID in order to bypass validation in the response, which only
ever checked for the top-level response
InResponseTofield, instead of alsoverifying the signed assertion-level
SubjectConfirmationData.InResponseTo.Internal ref: https://hashicorp.atlassian.net/browse/SECVULN-50330
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.