Icu 18817 backup - #59
Open
Rkabra7 wants to merge 8 commits into
Open
Conversation
…l, Makefile, worker-pvc_test.yaml
Rkabra7
force-pushed
the
ICU-18817-backup
branch
17 times, most recently
from
July 14, 2026 18:07
6378907 to
5f173d2
Compare
…nts, fix readyz check
Rkabra7
force-pushed
the
ICU-18817-backup
branch
from
July 15, 2026 17:11
5f173d2 to
27c9985
Compare
MayukhSobo
reviewed
Jul 28, 2026
smayukh
requested changes
Jul 28, 2026
smayukh
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please review the PR comments.
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 1 out of 2 committers have signed the CLA.
Have you signed the CLA already but the status is still pending? Recheck it. |
smayukh
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds values.openshift.yaml with ready-to-use OpenShift overrides.
Adds an OpenShift Route template to provide TCP passthrough access to the worker proxy port.
Switches the proxy Service to ClusterIP when OpenShift support is enabled, with the Route handling external traffic.
Applies an OpenShift-compatible security context by removing fixed UID/GID settings so SCC can assign values from the namespace range.
Makes PVC storageClass conditional, allowing the cluster default storage class to be used when left unset.
Adds a new openshift: configuration section to values.yaml (disabled by default).
Adds unit tests covering all new OpenShift-specific paths.
Behaviour Changes
recording-storage mount is now always present (all users, not just OpenShift):
Previously, the recording-storage volumeMount was only added when worker.persistence.recording.enabled=true.
It is now always mounted — using a real PVC when recording is enabled, or a non-persistent emptyDir when it is not.
This ensures the worker process always has a writable path at the recording mount point regardless of whether
recording is configured, which prevents startup failures on clusters where the path must exist.
Testing
Tested on OpenShift Local (CRC). The worker successfully authenticated to a self-managed Boundary controller using the OpenShift-specific chart configuration.
Checklist
I have documented a clear reason for, and description of, the change I am making.
Added/updated tests or validation steps (if applicable)
Verified local lint/validation
No breaking changes, or clearly documented
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
PCI review checklist
I have documented a clear reason for, and description of, the change I am making.
If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
If applicable, I've documented the impact of any changes to security controls.
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.