fix(ci): evaluate jq interpolations in skill-review detailed output - #71
Merged
gautambaghel merged 1 commit intoMay 11, 2026
Merged
Conversation
The DESC_EVAL and CONTENT_EVAL jq programs used `\\(.key)` /
`\\(.value...)` inside a single-quoted format string. In jq, `\\` is an
escaped backslash, so the program contains a literal backslash followed
by `(.key)` — not an interpolation — and the PR comment renders as
\(.key): \(.value.score)/3 - \(.value.reasoning)
for every criterion (e.g. PR hashicorp#66, PR hashicorp#64).
Drop the redundant backslash so jq evaluates the interpolation. The
surrounding `join("\\n")` and `"\\n\\n"` are intentionally kept — those
literal `\n` tokens are consumed downstream by `printf '%b'`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Detailed Review section of every
Tessl Skill ReviewPR comment renders per-criterion lines as literal text instead of real scores — e.g. PR #66, PR #64:Cause and fix
Lines 228 and 234 of
.github/workflows/tessl-skill-review.ymlover-escape jq interpolations. The jq program is single-quoted in bash, so jq sees\\(.key)—\\is an escaped backslash, leaving a literal\before(.key)that jq prints verbatim instead of interpolating.Surrounding
\\nsequences are intentionally kept — they're consumed downstream byprintf '%b'.Test plan
Reproduced the upstream workflow verbatim (real
tessl skill review --jsonagainst a sample skill, no API key) and confirmed:\(.key): \(.value.score)/3 - \(.value.reasoning)specificity: 2/3 - It mentions 'print a hello world greeting' ...Table, score column, suggestions, and
<details>collapsing render identically before/after. Does not touch theTABLE=/DETAILS=lines fixed in #67.