Repository navigation
fix(cli): guard boolean --pool flag in sync and mandate @latest in readme - #333
Merged
Merged
Conversation
…ll in readme Why: - In `src/cli/sync.ts`, passing `memory sync --pool` without an argument evaluated `parsed.flags.pool` as string `"true"`, causing path resolution to create a stray `./true` directory. - Documentation in `README.md` needed to mandate `@latest` across package managers and outline 3-tier upgrade workflows (global, project, storage). - Backlog in `.agents/context/` required Wave 23–29 tickets and the local Agent OS (Rashin) research artifact. What: - In `src/cli/sync.ts`: filter out `"true"` and empty strings so `poolDir` defaults to standard pool path when no explicit path is given. - In `test/sync.test.ts`: add regression test verifying no `./true` directory is created when `--pool` is passed as boolean `"true"`. - In `README.md`: mandate `@latest` for bun/npm/pnpm/yarn/npx and document 3-tier update guides. - In `CHANGELOG.md`: record CLI sync fix and README updates under `[Unreleased]`. - In `.agents/context/`: track Wave 23–29 tickets and commit research artifact. Verification: - `bun test test/sync.test.ts`: 18/18 pass. - `bun test test/marketing_claims.test.ts test/published_copy_contracts.test.ts`: 38/38 pass. - `bun run scripts/showreel-hash.ts --check`: in sync. - `bun run scripts/check-doc-links.ts`: 150/150 markdown links resolve. - `bun run typecheck` (tsc --noEmit): clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--poolfix: Prevents boolean string"true"from resolving as relative directory./truewhenmemory sync --poolis passed without an explicit directory argument.README.mdModernization: Mandates@latestacross all package managers (bun,npm,pnpm,yarn,npx) and documents the 3-tier update model (CLI/workstation, project/workspace, and storage self-healing).Verification Evidence
bun test test/sync.test.ts18/18 pass).bun test test/marketing_claims.test.ts test/published_copy_contracts.test.ts38/38 pass).bun run scripts/showreel-hash.ts --check).bun run scripts/check-doc-links.ts150/150 resolve).tsc --noEmit).[Unreleased].