fix: hoist intToString() temporaries to avoid dangling strValue pointers

[dimitri]

The bug

intToString() returns an IntString struct by value. Taking .strValue from the result inline:

paramValues[1] = intToString(port).strValue;

stores a pointer into a temporary struct that is destroyed at the end of the statement. Any subsequent read of paramValues[1] — including the pgsql_execute_with_params() call a few lines later — reads freed stack memory. This is undefined behaviour; in practice it produces garbage bytes in libpq parameter arrays, which propagate into PostgreSQL error messages and can cause UnicodeDecodeError in any Python code that processes those messages.

Clang catches this with -Wdangling-assignment.

The fix

Declare a named IntString variable at function scope so that .strValue remains valid across the entire parameter-building and query-execution block:

IntString portStr = intToString(port);
paramValues[1] = portStr.strValue;
/* ... fill remaining paramValues ... */
pgsql_execute_with_params(..., paramValues, ...);   /* safe: portStr still in scope */

Files changed

File	Instances fixed
src/bin/pg_autoctl/monitor.c	20 — across 13 functions
src/bin/pg_autoctl/coordinator.c	10 — across 5 functions
src/bin/pg_autoctl/demoapp.c	8 — across 3 functions
src/bin/pg_autoctl/pgctl.c	1 — pg_ctl_postgres args array
src/bin/pg_autoctl/pgsql.c	1 — send_node_active_message loop
src/bin/pg_autoctl/ipaddr.c	1 — fetchLocalIPAddress GetAddrInfo call

41 instances total. No logic changes; only the lifetime of the intermediate struct is extended.

citus_indent --check passes. -Wdangling-assignment is clean after this change.