ci: replace ad-hoc linting job with citus/stylechecker:no-py style check - #1126
Merged
Conversation
Move C formatting and banned-function checks out of the test matrix into a dedicated style_checker job that runs in the official citus/stylechecker:no-py container. This guarantees the same citus_indent version is used locally (via the new docker-check / docker-indent Makefile targets) and in CI. Changes: - Add style_checker job: citus_indent --check + ci/banned.h.sh - Remove PGVERSION=14 TEST=linting matrix entry and its three conditional steps (install tools, make lint, build-docs) - Remove LINTING and TRAVIS_BUILD_DIR env vars (dead code from the Travis era) - Remove linting case from ci-test and test Makefile targets - Update actions/checkout from v3 to v4.2.2 - Add docker-indent / docker-check Makefile targets for local use - Fix YAML indentation on branch triggers (cosmetic)
PG13 reached EOL in November 2025. PG18 is not yet supported (packages missing on Debian bullseye). Supported matrix is now PG14–17.
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move C formatting and banned-function checks out of the test matrix into a dedicated
style_checkerjob that runs in the officialcitus/stylechecker:no-pycontainer. This guarantees the samecitus_indentversion is used locally and in CI, and removes an awkward conditional matrix entry that was skipping the build steps.Changes
.github/workflows/run-tests.ymlstyle_checkerjob:citus_indent --check+ci/banned.h.shin the stylechecker containerPGVERSION: 14 / TEST: lintingmatrix entry and its three conditional steps (install tools,make lint, build-docs)LINTINGandTRAVIS_BUILD_DIRenvironment variables (dead code from the Travis era)if: ${{ env.TEST != 'linting' }}guards on build and test stepsactions/checkoutfrom v3 to v4.2.2Makefilelintingcase fromci-testandtesttargetsCITUS_INDENT_DOCKERvariable anddocker-indent/docker-checktargets so contributors can run the exact CI formatter locally without installingcitus_indentspellchecktarget to use$(CITUS_INDENT_DOCKER)somake spellcheckmatches CIBefore / after
Before: the linting job installed
black,uncrustify, and Citus tools on the raw GitHub runner, adding ~2 minutes of setup and using whatever version ofcitus_indentwas built fromci/tools.mk. The matrix had an awkward conditional entry that skipped the Docker build entirely.After: style check runs in
citus/stylechecker:no-py— the same pinned container used by the Citus project — taking ~20 seconds. The test matrix is uniform: every entry builds and runs.