Apple Photo Library still only considering downloaded files

[movinimage]

Hello!

I am using .74

Apple Photos import is still only pulling the downloaded files. I checked inside the package and there are thousands of files in the derivatives folder. Can I share any logs to help?

Thank you!

[hanxiao]

Thank you for the report, and for checking inside the package - that detail is what pinned it down.

You were looking at the right thing. Those derivatives are exactly what Omni should have been reading, and it was refusing them.

What was wrong. Every image request Omni makes to PhotoKit set isSynchronous. That flag is documented to ignore deliveryMode and behave as .highQualityFormat, which is contractually obliged to refuse an asset whose only local copy is a smaller derivative when the network is off. So the fix from #13 - ask for .opportunistic so an Optimize Mac Storage derivative is accepted - never actually took effect. The asset passed the "is anything local" check, then decoded to nothing, and produced no rows, no error and no log line. That is why it looked like only downloaded files were being considered.

Fixed in 0.8.1: https://github.com/hanxiao/omni-macos/releases/tag/v0.8.1

Requests are asynchronous now, so the delivery mode means something. The decode asks for the full-quality render first, which leaves a downloaded photo decoded exactly as before, and falls back to the resident derivative when that is all there is. Nothing is downloaded from iCloud either way, so you can leave Settings > Files > iCloud on "Skip".

After updating, press Update in Settings > Storage. Photos that were skipped have no rows stored, so a normal pass picks them up without a full reindex.

One thing that would help. 0.8.1 also adds a count, because this was invisible: Settings > Storage now shows "Photos not on this Mac" in the Index section, and only when it is above zero. If your library still comes up short after the pass, that number tells us whether Omni is still refusing them or whether something else is going on.

I could not reproduce this locally - the library on my machine has 12 assets and they are all downloaded, so the derivative path never triggers here. The fix follows from the documented API behaviour rather than from a before and after I could measure. So I would be grateful if you would confirm on your library.