term_methods: correct piece attacks mask | correct rook on 7th - #196
Merged
Conversation
Previously we only accounted for the last attack mask as we overwrote the entry for each piece... Instead we should ofc account for all the attacks by all the pieces. Signed-off-by: Hans Binderup <hbinderup94@gmail.com>
Instead of using the "rooks" mask for computing the 7th row score we should use the currently iterated piece. Bench 1318970 Signed-off-by: Hans Binderup <hbinderup94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See each commit :)