Allow to use Patch.patch and Patch.pp_hunk on large diffs with OCaml 4 - #30
Merged
kit-ty-kate merged 5 commits intoJun 2, 2025
Merged
Conversation
kit-ty-kate
force-pushed
the
fix-large-diff-support-ocaml4
branch
from
June 2, 2025 00:55
11f7e7a to
f859021
Compare
…large diffs with OCaml 4
List.map and (@) were not tail-recursive so it would stack overflow
This also allows to use Patch.patch on large diffs when using OCaml 4 as (@)/List.append is not tail-recursive with OCaml 4
kit-ty-kate
force-pushed
the
fix-large-diff-support-ocaml4
branch
from
June 2, 2025 00:59
f859021 to
14c6170
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ocaml/opam#6513
Queued on top of #29
Part of the patches are ported from #24
(@)andList.mapare not tail-recursive with OCaml < 5.1TODO: add tests