Skip to content

Adds linters and Github Actions - #2

Draft
wgh000 wants to merge 2 commits into
hanagantig:mainfrom
wgh000:main
Draft

Adds linters and Github Actions#2
wgh000 wants to merge 2 commits into
hanagantig:mainfrom
wgh000:main

Conversation

@wgh000

@wgh000 wgh000 commented Jun 17, 2021

Copy link
Copy Markdown

Code has been lint'ed
Github Actions runs linters and tests to accept push and pull-requests

Comment thread logger.go
}

// DefaultLogger is used if none is specified.
func createDefaultLogger() Logger {

@hanagantig hanagantig Jun 17, 2021

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this way we will create multiple logger structs that will lead to different mutexes in logger atomic methods

@hanagantig
hanagantig marked this pull request as draft December 26, 2021 17:59
@hanagantig

Copy link
Copy Markdown
Owner

@wgh000 could you please change the createDefaultLogger() method so I can merge your first cool PR ? 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants