Document further commons RPC gaps (D9-D17) + reject inert @tagged/@methodTag/@paramTag (D10) - #20
Open
halotukozak wants to merge 4 commits into
Open
Document further commons RPC gaps (D9-D17) + reject inert @tagged/@methodTag/@paramTag (D10)#20halotukozak wants to merge 4 commits into
halotukozak wants to merge 4 commits into
Conversation
This was referenced Aug 10, 2026
Closed
halotukozak
force-pushed
the
d10-tag-guard-v2
branch
from
August 10, 2026 07:57
a5bb66d to
c0d319d
Compare
Ported a feature-by-feature comparison against the actual AVSystem/scala-commons rpc/meta source (fully generic raw-method framework, tag-driven routing, interceptors, @tried, ADT metadata, reflective metadata richness, Fallback/ MacroInstances) and catalogued each confirmed gap the same way D1-D8 already do. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
They compiled and silently did nothing under mrpc's fixed fire/call/get RawRpc (no tag-selection branch exists to steer, D9) — a landmine, not a no-op. hasAnnotation[X[?]] guards in Plans.materialize (trait-level @methodTag/@paramTag) and OpPlan.materialize/ParamPlan.encodingOf (method-/param-level @tagged) turn that into a compile error instead. The wildcard type arg matches every instantiation despite these annotations being invariant in their type parameter. Real tag-driven routing still needs the generic raw-method framework (D9); this closes only the silent-no-op landmine, not the underlying gap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
force-pushed
the
d10-tag-guard-v2
branch
from
August 10, 2026 08:15
c0d319d to
f8b6548
Compare
halotukozak
added a commit
that referenced
this pull request
Aug 19, 2026
D9 is not a typo: PR #20 (open, not yet merged) adds a legitimate D9 entry ("RawRpc is a fixed trait, not the generic raw-method framework") that the D7 text was correctly forward-referencing. D8 is a narrower, distinct entry (generic methods/@composite/interceptors as a scope boundary), not the same concept. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
# Conflicts: # src/mrpc/derive/OpPlan.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends DIVERGENCES.md with D9-D17: comparison against the actual AVSystem/scala-commons rpc/meta source (generic raw-method framework, tag-driven routing, interceptors, @tried, ADT metadata, reflective metadata, Fallback/MacroInstances).
Closes the D10 landmine: @tagged/@methodTag/@paramTag used to compile and do nothing under mrpc's fixed fire/call/get RawRpc. Now a compile error via hasAnnotation[X[?]] guards in Plans.materialize (trait-level @methodTag/@paramTag) and OpPlan.materialize/ParamPlan.encodingOf (method-/param-level @tagged). test/mrpc/parity/TagAnnotationsRejectedSuite.scala covers all three at both method and param position.
Real tag-driven routing still needs the generic raw-method framework (D9) - this only closes the silent no-op.