Adapt to made's getAnnotation: Option[A] -> A | Null - #4
Merged
Merged
Conversation
…on[A] made's getAnnotation[A] changed from Option[A] to A | Null (mcodec was pinned to a made commit predating this change). deriveSum's flatten-tag lookup called .fold directly on the result, which only exists on Option. Wrapping in Option(...) restores identical behavior (null -> None) and works regardless of the caller's -Yexplicit-nulls setting. Verified: compiles and all existing tests pass (0 failures) against the real published made:0.3.0. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
added a commit
to halotukozak-com/mrpc
that referenced
this pull request
Aug 9, 2026
mcodec's old pinned commit predates made's getAnnotation Option[A] -> A | Null change (same root cause as the made pin bump in the previous commit). Repointing to the fix branch until halotukozak-com/mcodec#4 merges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The Renovate PR bumping made alone fails CI (getAnnotation now returns A | Null), and this branch's compat fix alone still pins made 0.1.3 so never actually exercises the new API. Bump the dependency here so the fix and the version move land together. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 81.45% 81.37% -0.08%
==========================================
Files 18 18
Lines 1294 1294
==========================================
- Hits 1054 1053 -1
- Misses 240 241 +1 see 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
halotukozak
added a commit
to halotukozak-com/mrpc
that referenced
this pull request
Aug 9, 2026
mcodec's old pinned commit predates made's getAnnotation Option[A] -> A | Null change (same root cause as the made pin bump in the previous commit). Repointing to the fix branch until halotukozak-com/mcodec#4 merges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
added a commit
to halotukozak-com/mrpc
that referenced
this pull request
Aug 10, 2026
mcodec's old pinned commit predates made's getAnnotation Option[A] -> A | Null change (same root cause as the made pin bump in the previous commit). Repointing to the fix branch until halotukozak-com/mcodec#4 merges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
halotukozak
added a commit
to halotukozak-com/mrpc
that referenced
this pull request
Aug 10, 2026
mcodec's old pinned commit predates made's getAnnotation Option[A] -> A | Null change (same root cause as the made pin bump in the previous commit). Repointing to the fix branch until halotukozak-com/mcodec#4 merges. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcodec is pinned (via mrpc's CI) to a
madecommit that predates a breaking API change:getAnnotation[A]now returnsA | Nullinstead ofOption[A].deriveSum's flatten-tag lookup called.folddirectly on the result, which only exists onOption.Option(m.getAnnotation[mcodec.annotation.flatten]).fold("_case")(_.key)restores identical behavior (null->None) and works regardless of-Yexplicit-nulls.Test plan
made:0.3.0(verified locally)made:0.3.0— 0 failures across all suites (verified locally)🤖 Generated with Claude Code