Skip to content

reduce compilation time by concrete class implementation - #163

Merged
halotukozak merged 4 commits into
mainfrom
reduce-compialtion-time-by-concrete-classes-impl
Sep 3, 2026
Merged

reduce compilation time by concrete class implementation#163
halotukozak merged 4 commits into
mainfrom
reduce-compialtion-time-by-concrete-classes-impl

Conversation

@halotukozak

Copy link
Copy Markdown
Collaborator

Description

Checklist

  • scalafmt run (or equivalent formatter for this repo)
  • Tests added/updated where relevant
  • CI passes

Copilot AI lite review requested due to automatic review settings September 3, 2026 09:20

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the needs-major Binary-incompatible change — needs a major version bump label Sep 3, 2026
@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@halotukozak
halotukozak force-pushed the reduce-compialtion-time-by-concrete-classes-impl branch from fb91c18 to f6a202f Compare September 3, 2026 16:13
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

⚠️ MiMa: binary incompatibility vs main@893215d

This PR breaks binary compatibility — it will need a major version bump.

Details
[mima] backward (code built against the release vs the new JAR): 11 problem(s)
  - interface halotukozak.made.Done#DoneOperationWorkaround does not have a correspondent in current version
  - interface halotukozak.made.Done#DoneWorkaround does not have a correspondent in current version
  - interface halotukozak.made.GeneratedMadeElemWorkaround does not have a correspondent in current version
  - interface halotukozak.made.InputElemWorkaround does not have a correspondent in current version
  - interface halotukozak.made.Made#ProductWorkaround does not have a correspondent in current version
  - interface halotukozak.made.Made#SingletonWorkaround does not have a correspondent in current version
  - interface halotukozak.made.Made#SumWorkaround does not have a correspondent in current version
  - interface halotukozak.made.Made#TransparentWorkaround does not have a correspondent in current version
  - interface halotukozak.made.MadeFieldElemWorkaround does not have a correspondent in current version
  - interface halotukozak.made.MadeSubElemWorkaround does not have a correspondent in current version
  - interface halotukozak.made.MadeSubSingletonElemWorkaround does not have a correspondent in current version
[mima] forward  (new API vs the release — expected to list additions): 18 problem(s)
  - class halotukozak.made.DoneImpl does not have a correspondent in current version
  - class halotukozak.made.DoneOperationImpl does not have a correspondent in current version
  - class halotukozak.made.EmptyDoneOperationImpl does not have a correspondent in current version
  - class halotukozak.made.FieldElemImpl does not have a correspondent in current version
  - class halotukozak.made.GeneratedFieldElemImpl does not have a correspondent in current version
  - static method ordinal(halotukozak.made.InputElem)Int in interface halotukozak.made.InputElem does not have a correspondent in current version
  - the type hierarchy of object halotukozak.made.InputElem is different in current version. Missing types {scala.deriving.Mirror$Sum,scala.deriving.Mirror}
  - method ordinal(halotukozak.made.InputElem)Int in object halotukozak.made.InputElem does not have a correspondent in current version
  - class halotukozak.made.InputElemImpl does not have a correspondent in current version
  - object halotukozak.made.InputElemImpl does not have a correspondent in current version
  - class halotukozak.made.MadeProductImpl does not have a correspondent in current version
  - class halotukozak.made.MadeSingletonImpl does not have a correspondent in current version
  - class halotukozak.made.MadeSumImpl does not have a correspondent in current version
  - class halotukozak.made.MadeTransparentImpl does not have a correspondent in current version
  - class halotukozak.made.SingleDoneOperationImpl does not have a correspondent in current version
  - class halotukozak.made.SubElemImpl does not have a correspondent in current version
  - object halotukozak.made.SubElemImpl does not have a correspondent in current version
  - class halotukozak.made.SubSingletonElemImpl does not have a correspondent in current version

@halotukozak
halotukozak merged commit b26b20b into main Sep 3, 2026
9 checks passed
@halotukozak
halotukozak deleted the reduce-compialtion-time-by-concrete-classes-impl branch September 3, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-major Binary-incompatible change — needs a major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants