chore: post-v2.5 review — docs, screenshots, cluster hardening, roadmap#19
Merged
Conversation
…roadmap Documentation accuracy: - bootstrap.py: "Python 3.11+" -> "3.10+" (CI/requirements support 3.10). - README (TR/EN): correct the data-file permission wording (the data DIR is locked 0700/icacls, not each file to 0600). - ROADMAP: move shipped items out of "Planned" (OIDC SSO, REST token roles, light/dark theme, xterm fit-to-window, packaging, LAN cluster) into Shipped; rewrite the forward plan (cluster depth/hardening, IIoT, packaging, CI Node-24). Screenshots: - Regenerate from the running UI; the capture tool now starts a second cluster node so the dashboard's LAN-cluster panel shows a real multi-host fleet view. - Add docs/screenshots/06-cluster.png; show it + the cluster panel in both READMEs. Cluster code-review fixes (from the v2.5 review): - cluster.py: close the UDP socket if create_datagram_endpoint() fails (no leak). - config.py: ClusterSettings.validate raises a clean ConfigError on a non-numeric discovery_port instead of a raw ValueError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full review pass after the v2.5 LAN-cluster release: documentation audited against the code, screenshots refreshed, two cluster fixes from the code review, and the roadmap brought up to date.
Documentation accuracy
requirements.txtship 3.10 backports; the matrix is 3.10–3.13).config.jsonis0600on POSIX. The code locks the data directory to0700(POSIX) /icacls(Windows); files inside inherit that. Reworded to match.Screenshots
docs/screenshots/06-cluster.png; surfaced it (and the cluster panel) in both READMEs.Cluster code-review fixes
cluster.py: close the UDP socket ifcreate_datagram_endpoint()fails after bind (avoids a socket leak on repeated enable/disable).config.py:ClusterSettings.validate()now raises a cleanConfigErroron a non-numericdiscovery_portinstead of a rawValueError.Other review findings (peer-IP SSRF guard, TLS pinning for peer fetch, IPv6 discovery, a rate-limit on
/api/cluster/local) are lower-severity / require the shared key to exploit; they're captured as the v2.6 cluster-hardening backlog in ROADMAP.Verification
run_all.py --socat); ruff clean.