Code Review#2
Open
mosdevly wants to merge 1 commit into
Open
Conversation
Great job overall. You've definitely shown some improvement in some areas: - Great job using functions to break down the code - Great commenting - Small improvement with use of space - Creative solutions to animations and transitions! - Well done usage of Codepen for snippets! But you've really got to work on neatness and polish. - Typos are OK -- but constant mispellings cause you to make mistakes and breaks readability. - Spacing: Use a linter and install some tools help you keep things neat - Variable names need a lot of work. These may seem nitpicky but code that's readable is also codew with far fewer bugs. It's code that makes errors easier to find. It's code that helps you to literally see what's missing, can be improved, or is broken. Resources: - https://git.generalassemb.ly/sf-wdi-43/study-resources/blob/master/editor_cheatsheet.md This is really well done and I'm really glad to see you take pride in your CSS and design! I hope you enjoyed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Great job overall. You've definitely shown some improvement in some areas:
But you've really got to work on neatness and polish.
These may seem nitpicky but code that's readable is also codew with far fewer bugs. It's
code that makes errors easier to find. It's code that helps you to literally see what's
missing, can be improved, or is broken.
Resources:
This is really well done and I'm really glad to see you take pride in your CSS and design!
I hope you enjoyed it.