fix(calculations): align solver with multi-person projections & fix OAS calculations - #36
Merged
Merged
Conversation
…ver with multi-person projections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two major calculation issues in the retirement engine:
Household OAS Calculation:
SummaryCardcalculations did not account for OAS at all, whileIncomeBreakdownCardevaluated a single hardcoded OAS max of $9,024 when the household retirement age reached 65+.ProjectionContext. It dynamically verifies eligible seniors based on their age at the household retirement point (meaning a dual-income household where both turn 65+ during retirement gets two OAS estimates, which is correct).Additional Savings Solver Synchronization:
calculate_additional_annual_savingsmethod using simple parameters, which assumed continuous savings and compound growth for all accounts until retirement.$0/yearadditional savings recommendations when a gap actually existed.