fix(ui): overall track status should factor in after-tax status - #35
Merged
Conversation
…intain visual consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a logical discrepancy in the
SummaryCardoverall status reporting.Bug:
If a user was on-track for their pre-tax target (100% progress) but had an after-tax gap (e.g. 98% progress due to RRSP tax rates), the card still painted itself green, showed the "You're on Track!" check icon/header, but printed a "Save an additional $X/year" warning callout at the bottom.
Fix:
Defined
isOverallOnTrackwhich checks both pre-tax progress and after-tax progress (when a tax rate is active). The card's background color, header icon, and status title text now accurately reflect your combined track status.