Skip to content

fix(nushell): register set-java-home as hook#271

Open
lassoColombo wants to merge 1 commit into
halcyon:masterfrom
lassoColombo:fix-nushell-set-env-script
Open

fix(nushell): register set-java-home as hook#271
lassoColombo wants to merge 1 commit into
halcyon:masterfrom
lassoColombo:fix-nushell-set-env-script

Conversation

@lassoColombo

Copy link
Copy Markdown

Problem

The current set-java-home.nu defines asdf_update_java_home but never invokes it and never registers it as a hook. As a result, sourcing the script is a no-op:
JAVA_HOME and JDK_HOME are simply never set.

Proposal

Follow the pattern already established for other shells:

  • Make the function an --env function so it can actually mutate the caller's environment
  • Register it as a hook so the values track the active java version as the user moves around

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant