Fix hex encoding in payload String() methods - #21
Merged
Conversation
Fix String() methods in GetPortsResponse, GetType, and GetTypeResponse to use %X instead of %s for byte data. Also set dataLength in GetPortsResponsePayload for consistency with other payload constructors.
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Good catch on the logging in #19, sorry about that! Fixed the String() methods in the payload types from #20 (GetPortsResponse, GetType, GetTypeResponse) to use
%Xinstead of%sfor byte data. Also set the missingdataLengthin GetPortsResponsePayload for consistency.Looks like the other payload String() methods have the same
%sissue with byte data - happy to send a cleanup PR for those too if you'd like.