Implement port management (ADD_PORT, INHERIT_PORT, REMOVE_PORT) - #18
Merged
Conversation
Addresses the first two TODOs from README: - "Assign new door to the gateway" - "Delete assigned door from the gateway" SDK changes: - Add command ID constants for ADD_PORT (0x29), INHERIT_PORT (0x41), REMOVE_PORT (0x42) and their response variants - Add PortIdResponse and RemovePort payload types - Add Client.AddPort(), Client.InheritPort(), Client.RemovePort() - Add configurable read timeout to transmitCommand (pairing needs ~40s) - Wire up response decoders in Packet.go CLI changes: - Add "ports" command group with subcommands: add, inherit, remove - "ports add": clone hand remote signal (ADD_PORT) - "ports inherit": transmit gateway code for motor to learn (INHERIT_PORT) - "ports remove": delete a paired port (REMOVE_PORT) Pairing procedures tested against a ProMatic 3 (firmware EE001425-14). Proximity requirements and feedback support may vary with other motors.
Owner
|
@alexbartok can you please have a look on my d1e456e commit? Just to make sure my merge conflict resolution is correct before merge your PR. Thanks! |
Contributor
Author
|
@halacs Merge resolution looks good, everything came through correctly. Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the first two TODOs from the README:
Adds
portsCLI command group withadd,inherit, andremovesubcommands. SDK methods, payload types, and response decoders follow existing patterns (modeled after user management).Pairing commands use a 45-second read timeout since the gateway listens/transmits for ~40 seconds. Tested against a ProMatic 3 (firmware EE001425-14). Proximity requirements and feedback support may vary with other motors.
Thanks to @halacs for this project, which was essential for building my own garage door integration.