Repository navigation
feat: add synchronous host render event phase (M2DX #119) - #20
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AUホストのオートメーション後に別のコントロール設定を編集すると、Coreの新しいスナップショットで発音側だけが旧値へ戻り、保存値と一致しなくなります。M2DX #119 の統合に必要な、スナップショット適用後の同期
processEventsコールバックと、FIFOを使わないMIDI／パラメーター処理APIを追加します。ホストは保持中の値を復元してから当該ブロックのイベントを順に適用できます。FMエンジン・オーバーサンプリング・サンプルレート・ボイス上限の準備をイベント処理より前へ移しました。これにより切替直後のNote Onが消えることと、LAYER拡張直後に旧上限で声を割り当てることを防ぎます。パラメーターの音量とMIDI CC7の音量は独立して処理します。
追加APIとして1.23.0を準備。アプリは正式タグ公開後に統合します。アプリ側の保持値管理・実ホスト検証は M2DX #119 に残るため、このPRでは同IssueをCLOSEしません。