Skip to content

Fix broken links #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nsutcliffe wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix broken links #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb46baf
Fix broken link
nsutcliffe Jan 14, 2025
4805606
Fix broken link
nsutcliffe Jan 14, 2025
0dd5ba9
Merge branch 'master' into fix-broken-links
nsutcliffe May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/src/main/scala/skuber/api/client/impl/KubernetesClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -668,7 +668,7 @@ class KubernetesClientImpl private[client] (val requestMaker: (Uri, HttpMethod)
* Discards the response
* This is for requests (e.g. delete) for which we normally have no interest in the response body, but Pekko Http
* requires us to drain it anyway
* (see https://doc.pekko.io/docs/pekko-http/current/scala/http/implications-of-streaming-http-entity.html)
* (see https://pekko.apache.org/docs/pekko-http/current/scala/http/implications-of-streaming-http-entity.html)
* @param response the Http Response that we need to drain
* @return A Future[Unit] that will be set to Success or Failure depending on outcome of draining
*/
Expand Down
2 changes: 1 addition & 1 deletion client/src/main/scala/skuber/api/dynamic/client/impl/DynamicKubernetesClientImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ class DynamicKubernetesClientImpl(context: Context = Context(),
* Discards the response
* This is for requests (e.g. delete) for which we normally have no interest in the response body, but Pekko Http
* requires us to drain it anyway
* (see https://doc.pekko.io/docs/pekko-http/current/scala/http/implications-of-streaming-http-entity.html)
* (see https://pekko.apache.org/docs/pekko-http/current/scala/http/implications-of-streaming-http-entity.html)
*
* @param response the Http Response that we need to drain
* @return A Future[Unit] that will be set to Success or Failure depending on outcome of draining
Expand Down
Loading