Skip to content

Fix flaky HomeController tests: use array cache in test env#755

Merged
allella merged 2 commits into
hackgvl:developfrom
kevindees:hotfix/fix-tests
Jul 1, 2026
Merged

Fix flaky HomeController tests: use array cache in test env#755
allella merged 2 commits into
hackgvl:developfrom
kevindees:hotfix/fix-tests

Conversation

@kevindees

Copy link
Copy Markdown
Contributor

Attempt to fix issues with seeder and caching.

@allella

allella commented Jul 1, 2026

Copy link
Copy Markdown
Member

@kevindees is CACHE_STORE the more current way (since ~ v11) to set the cache driver?

I had made a note in #741 about updating to the newer keys for the cache and mail drivers and the docs seem to support that we're using older names in our .env files and config/cache.php

https://laravel.com/docs/13.x/cache

@kevindees

Copy link
Copy Markdown
Contributor Author

@allella @oliviasculley

Do we want to include a fallback for CACHE_DRIVER or just use CACHE_STORE now? I'm working on the upgrade to CACHE_STORE from CACHE_DRIVER.

CleanShot 2026-07-01 at 16 19 44@2x

@allella

allella commented Jul 1, 2026

Copy link
Copy Markdown
Member

No strong feelings.

It seems like it's going to default to file for most dev environments because I don't image too many folks are setting up memcache or Redis on dev.

Unless there's something in the Docker setup (defer to @oliviasculley) that's worth keeping CACHE_DRIVER around, then I'd be good with outright replacing it.

I've already updated stage and production was already using CACHE_STORE and defaulting to file.

I figure we can expecting anybody using a fancy cache should be smart enough to look at .env.example and figure it out.

@allella
allella requested review from allella and oliviasculley July 1, 2026 21:04
@allella
allella merged commit f003d12 into hackgvl:develop Jul 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants