Set homepage org stat to only count active orgs#752
Merged
Conversation
Member
|
Seems like the tests are failing, I'd also like to see this change corresponding to a test that would fail if this were to ever stop working for some reason |
Member
Author
|
Yeah, the tests failing are from Kevin's most recent tests, per #750 I assigned that one to Kevin and it's probably good that we figure out the right strategy on that issue before adding more tests that may suffer the same fate. The issue appears to be tests that are using a factory and the seeders are adding similar, or other, test data that's breaking the expected assertion counts. |
oliviasculley
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live site is showing 80 active orgs, but we don't want to count 'inactive' orgs.
This is a one-liner to only count active orgs.