Skip to content

Move scribe depednency to production dependency#575

Merged
allella merged 5 commits into
hackgvl:developfrom
irby:feat/api-doc-explorer
Jul 9, 2025
Merged

Move scribe depednency to production dependency#575
allella merged 5 commits into
hackgvl:developfrom
irby:feat/api-doc-explorer

Conversation

@irby

@irby irby commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Resolves a dependency issue caused by #567

@allella

irby added 5 commits July 9, 2025 10:46
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
@allella
allella merged commit 3566e36 into hackgvl:develop Jul 9, 2025
1 check passed
@irby

irby commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Hmm @allella didn't notice that the autogenerated scribe docs hardcode the http://localhost into its documentation.
Can you run php artisan scribe:generate on the stage server?
I'll need to dig into a way we can possibly have it be dynamic so the base URL isn't hardcoded :/

EDIT: nevermind, I found the fix.

@irby irby mentioned this pull request Jul 9, 2025
oliviasculley pushed a commit to oliviasculley/hackgreenville-com that referenced this pull request Oct 12, 2025
* Move scribe depednency to production dependency

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>

* Update composer.lock

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>

* Revert "Update composer.lock"

This reverts commit c6898fe.

* Revert "Move scribe depednency to production dependency"

This reverts commit d402c7b.

* Revised composer.lock changes

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>

---------

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
oliviasculley pushed a commit to oliviasculley/hackgreenville-com that referenced this pull request Oct 12, 2025
* Move scribe depednency to production dependency

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>

* Update composer.lock

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>

* Revert "Update composer.lock"

This reverts commit c6898fe.

* Revert "Move scribe depednency to production dependency"

This reverts commit d402c7b.

* Revised composer.lock changes

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>

---------

Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants