Skip to content

Merge composer toolbar rows and improve alt-text sheet#163

Merged
malkoG merged 4 commits into
hackers-pub:mainfrom
malkoG:compose-toolbar-single-row
Jul 18, 2026
Merged

Merge composer toolbar rows and improve alt-text sheet#163
malkoG merged 4 commits into
hackers-pub:mainfrom
malkoG:compose-toolbar-single-row

Conversation

@malkoG

@malkoG malkoG commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Collapse ComposeScreen's two-row bottom toolbar into one row: image/poll icons, a new settings popover (Visibility + Quote Policy merged into one icon), language picker, and submit button.
  • Settings popover opens upward from the icon so it isn't clipped by the keyboard.
  • Alt-text (image annotation) bottom sheet: content now clears the system navigation bar, Auto-fill moved to the left with an explicit Save button and a "Saved" indicator on the right, and the sheet now opens fully expanded instead of a partial peek height.

Test plan

  • ./gradlew :app:compileDebugKotlin
  • ./gradlew :app:lintDebug
  • ./gradlew :app:testDebugUnitTest --tests "*ComposeScreenTest*"
  • Manual: open compose/reply screen, verify single-row toolbar and settings popover behavior
  • Manual: attach an image, verify alt-text sheet opens fully expanded, Auto-fill/Save/Saved-indicator layout, and clears the nav bar

malkoG added 4 commits July 18, 2026 20:55
…s popover

Collapses the two-row bottom toolbar in ComposeScreen into a single row by
replacing the separate Visibility and Quote Policy text buttons with one
icon-only settings button that opens a popover above the icon (avoiding the
keyboard) covering both option groups.
The MediaAttachmentEditorSheet's bottom content sat flush against the
device's navigation bar; add navigationBarsPadding() so it keeps a gap.
…(right)

Replaces the single right-aligned Auto-fill button with a row: Auto-fill on
the left, a "Saved" checkmark indicator once alt text is present, and an
explicit Save button on the right that closes the sheet.
ModalBottomSheet had no sheetState, so it defaulted to a partially
expanded peek height instead of opening at full height like every
other ModalBottomSheet in the app (see PostDetailScreen.kt), hiding
the Save/Auto-fill row until the user dragged it up.
@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@malkoG, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 17 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ead755cb-b325-42a8-ad09-d969f93ff17b

📥 Commits

Reviewing files that changed from the base of the PR and between 197b6cc and f7395f2.

📒 Files selected for processing (2)
  • app/src/main/java/pub/hackers/android/ui/screens/compose/ComposeScreen.kt
  • app/src/main/res/values/strings.xml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@malkoG
malkoG merged commit b69c56b into hackers-pub:main Jul 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant